[Gstreamer-bugs] [Bug 115886] Changed - gst_caps_has_(fixed_)property() prints an assertion before returning false

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=115886

Changed by rbultje at ronald.bitfreak.net.

--- shadow/115886	Mon Jun 30 17:59:09 2003
+++ shadow/115886.tmp.17811	Mon Jun 30 18:00:48 2003
@@ -63,6 +63,19 @@
 This has been tested on both Gentoo GNU/Linux and FreeBSD.
 
 ------- Additional Comments From rbultje at ronald.bitfreak.net  2003-06-30 17:59 -------
 Created an attachment (id=17940)
 patch
 
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-06-30 18:00 -------
+There's several ways to fix this:
+
+* change gstprops.c gst_props_has_property*() functions to check for
+props != NULL. This is ugly, imho, because that's what the caller
+should check.
+* change the macros to caps->properties != NULL && ..., which is ugly
+because you should never use variables-in-macros twice, they could be
+functions
+* fix this by making the macros inline functions
+
+The above patch implements the third fixage method.