[Gstreamer-bugs] [Bug 109558] Changed - cdparanoia: wrong discid when cd has a data track

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=109558

Changed by in7y118 at public.uni-hamburg.de.

--- shadow/109558	Sun Mar 30 14:31:26 2003
+++ shadow/109558.tmp.24967	Mon Mar 31 08:47:51 2003
@@ -19,6 +19,35 @@
 track.  two particular examples are "Beastie Boys - Hello Nasty" and "G
 Love and Special Sauce - Yeah It's That Easy."  The discid's are different
 than that reported by, for example, cd-discid-0.8 or ExactAudioCopy v0.90b4.
 
 Is it related to the fact that cdparanoia only reports the number of audio
 tracks, neglecting the number of data tracks?
+
+------- Additional Comments From in7y118 at public.uni-hamburg.de  2003-03-31 08:47 -------
+Could somebody mark this as CLOSED / NOTGNOME or whatever is the 
+appropriate solution for "this isn't supported in cdparanoia"?
+
+Reasons for that:
+Every track (audio and data) starts at an offset into the cd. This 
+offset is measured in 75th of a second. The discid is computed by 
+more or less checksumming these offsets (including the data tracks) 
+in various different ways.
+cdparanoia does store these offsets and there exists an API to query 
+them. This is properly used by the plugin.
+
+However:
+When opening the device and reading those offset informations, 
+cdparanoia might adjust the offsets of data tracks. Note: It does not 
+always adjust them, but it might. And it will never adjust offsets of 
+audio tracks. If it does adjust them, discid computation fails, 
+because the offsets reported by cdparanoia are wrong. There is no way 
+to xif this without modifying cdparanoia.
+
+proposed solution:
+I applied a patch that issues a g_warning upon g_object_get when the 
+discid might be wrong. I'm not sure if we should remove the discid, 
+since most of the times (no data tracks) the discid works correctly.
+However we can not guarantee a correct discid.
+I'm in favour of removing it.
+
+Comments? wtay?