[Gstreamer-bugs] [Bug 112014] Changed - [PATCH] quality min/max for vorbisenc are incorrect

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=112014

Changed by foser at gentoo.org.

--- shadow/112014	Fri May  2 12:26:00 2003
+++ shadow/112014.tmp.7892	Fri May  2 12:52:09 2003
@@ -28,6 +28,16 @@
 - vorbisenc allows to set values < 0 to use managed bitrate, that
 should still be allowed.
 - oggenc (the program) uses a quality from 0 to 10 with a default of
 3. Wouldn't it make more sense to simply divide by 10 when calling
 vorbis_encode_init_vbr? (Would require updating the default value from
 0.3 to 3)
+
+------- Additional Comments From foser at gentoo.org  2003-05-02 12:52 -------
+it looks like negative values are only determining if a quality is
+set, you can just as well check if a valid quality is set to do that.
+
+what oggenc does is not really relevant, i think it would be best to
+just follow the library specs.
+
+This error seems to come from the fact that parts of the vorbisenc
+seemed to be copied from oggenc.