[Gstreamer-bugs] [Bug 112607] Changed - fails to build gstgetbits_i386.s on Solaris x86 w/o gas

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=112607

Changed by ds at schleef.org.

--- shadow/112607	Thu May  8 20:52:30 2003
+++ shadow/112607.tmp.23776	Fri May  9 14:45:51 2003
@@ -1,12 +1,12 @@
 Bug#: 112607
 Product: GStreamer
-Version: 0.6.0
+Version: 0.6.x CVS
 OS: SunOS
 OS Details: 
-Status: NEW   
+Status: ASSIGNED   
 Resolution: 
 Severity: normal
 Priority: Normal
 Component: gstreamer (core)
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
 ReportedBy: hidetoshi.tajima at sun.com               
@@ -43,6 +43,15 @@
 decide which of .p2align or .aligh can be used.
 
 ------- Additional Comments From hidetoshi.tajima at sun.com  2003-05-08 20:52 -------
 Created an attachment (id=16378)
 a patch to use generic .align 16 instead of  gas-local .p2allign 4,7.
 
+
+------- Additional Comments From ds at schleef.org  2003-05-09 14:45 -------
+Applied to HEAD.
+
+.align 16 is almost always more correct than .palign 4,,7 in speed
+critical code (on i386, blah, blah, add lots of qualifiers here.)
+So I don't see a need to detect if gas can handle .p2align -- we
+should just use .align.
+