[Gstreamer-bugs] [Bug 113180] New - Some GstBuffer comments

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=113180

Changed by rbultje at ronald.bitfreak.net.

--- shadow/113180	Sat May 17 07:38:34 2003
+++ shadow/113180.tmp.11717	Sat May 17 07:38:35 2003
@@ -0,0 +1,35 @@
+Bug#: 113180
+Product: GStreamer
+Version: HEAD CVS
+OS: Linux
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: minor
+Priority: Normal
+Component: gstreamer (core)
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: rbultje at ronald.bitfreak.net               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: 0.6.x
+URL: 
+Summary: Some GstBuffer comments
+
+I'm going over the gstbuffer.h API currently, and have got some
+questions/comments on struct GstBuffer.
+
+1) size is a guint, maxsize is guint64. Why?
+
+This makes little sense. The size should always be optionally as large as
+maxsize (wy else is maxsize of any interest?). I suppose both should be a
+gulong or guint. guint64 is not interesting, since we're not dealing with
+whole *files* here, but just *buffers. If a buffer is larger than 4 gig,
+something is wrong upstream. Making it a guint64 is fine with me, but
+making maxsize/size a different type is quite weird.
+
+2) offset should be documented. Is it offset in the file, offset in the
+ring buffer, ...? It says media-specific, does it mean I can use it for
+anything? Please document it. Inside the .h file, that is. ;).
+
+3) there is no 'duration' (GstClockTime). This is interesting for VBR audio
+and subtitles.