[Gstreamer-bugs] [Bug 117342] Changed - [PATCH] Change types for callbacks from G_TYPE_POINTER to more specific type (eg, GST_TYPE_ELEMENT, etc).

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=117342

Changed by rbultje at ronald.bitfreak.net.

--- shadow/117342	Wed Nov 12 18:30:40 2003
+++ shadow/117342.tmp.29422	Thu Nov 13 03:54:39 2003
@@ -74,6 +74,30 @@
 
 Incidentally, I'm going to create a new patch soon that'll take care
 of all the cases I've come across in gstreamer (there are a bunch that
 were missed in the original patch), followed by an additional patch to
 the gst-plugins stuff (still not sure if I'll file a separate bug on
 that).
+
+------- Additional Comments From rbultje at ronald.bitfreak.net  2003-11-13 03:54 -------
+Dave just did most of this in the core, by the way...
+
+Dave, any reason why you're not using boxed in the closures (for
+GstBuffer and so on)? Glib provides boxed-type-g_closures for this
+reason (see grep -i boxed /usr/include/glib-2.0/gobject/* | grep
+closure). I think you're supposed to use these...
+
+     g_signal_new ("handoff", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST,
+                   G_STRUCT_OFFSET (GstIdentityClass, handoff), NULL,
+NULL,
+                   gst_marshal_VOID__POINTER, G_TYPE_NONE, 1,
+                   GST_TYPE_BUFFER);
+
+then becomes:
+
+     g_signal_new ("handoff", G_TYPE_FROM_CLASS(klass), G_SIGNAL_RUN_LAST,
+                   G_STRUCT_OFFSET (GstIdentityClass, handoff), NULL,
+NULL,
+                   gst_marshal_VOID__BOXED, G_TYPE_NONE, 1,
+                   GST_TYPE_BUFFER);
+
+I think glib/gtk use this too.