[Gstreamer-bugs] [Bug 118473] Changed - mplex plugin does not work on Solaris

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=118473

Changed by thomas at apestaart.org.

--- shadow/118473	Sun Aug 17 19:45:19 2003
+++ shadow/118473.tmp.761	Tue Feb 24 11:46:42 2004
@@ -6,15 +6,15 @@
 Status: RESOLVED   
 Resolution: FIXED
 Severity: normal
 Priority: Normal
 Component: gst-plugins
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
-ReportedBy: brian.cameron at ireland.sun.com               
+ReportedBy: brian.cameron at sun.com               
 QAContact: gstreamer-maint at bugzilla.gnome.org
-TargetMilestone: HEAD
+TargetMilestone: 0.7.x
 URL: 
 Summary: mplex plugin does not work on Solaris
 
 The mplex plugin fails on Solaris due to a few problems.
 
 + Forte does not support __inline__.  It does support "inline".
@@ -39,18 +39,18 @@
   error slips by gcc, but Forte noticed it.
 
 Two are addressed in the attached patch.  I am not sure how to best
 address the last issue mentioned, since my first shot was killed.
 See bug 118304.
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 05:54 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 05:54 -------
 Created an attachment (id=18672)
 patch to fix Forte compile problems
 
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 07:21 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 07:21 -------
 
 A few other Forte issues that I didn't mention before.
 
 + In gst-libs/ext/mplex/yuv4mpeg_ratio.cc
   The function strchr on Solaris returns "const char *".  Therefore
   in the function y4m_parse_ratio, it would be better if 
@@ -72,18 +72,18 @@
 tools don't use -lc, c++ tools should never use -lstdc++ directly in
 their Makefile.am.
 
 re: strchr(): you're right. Could you commit a fix that fixes both
 these? I'll look at your patch later today, I'm at work right now.
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 09:08 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 09:08 -------
 Created an attachment (id=18677)
 updated patch
 
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 09:09 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 09:09 -------
 The updated patch addresses everything except the problem with 
 vector.cc.  Once again, it fails to compile with this error:
 
   "vector.cc", line 12: Error: Cannot assign Aunit* to Aunit**.
 
   On this line:
@@ -103,39 +103,39 @@
 me. However, for the other part (the part where you use g_new()), I'd
 appreciate if you didn't use glib inside here, since it's supposed to
 be backportable. Please use new and delete instead.
 
 For the last part, I don't know yet.
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 11:48 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 11:48 -------
 Created an attachment (id=18683)
 updated patch to use new/delete
 
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 11:50 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 11:50 -------
 Created an attachment (id=18684)
 fix to patch - removed glib.h include
 
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-07-28 11:51 -------
+------- Additional Comments From brian.cameron at sun.com  2003-07-28 11:51 -------
 Created an attachment (id=18685)
 argh!  this patch removes the broken fix to yuv4mpeg_ratio.cc
 
 
 ------- Additional Comments From ds at schleef.org  2003-07-28 15:46 -------
 > "vector.cc", line 12: Error: Cannot assign Aunit* to Aunit**.
 
 This appears to be a bug in your compiler.  The new returns an (Auint
 **), as I understand it.
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-08-13 10:40 -------
+------- Additional Comments From brian.cameron at sun.com  2003-08-13 10:40 -------
 Could we create the buf statically, as suggested in my patch.  This
 technique works with the Forte compiler and, by avoiding calling new,
 avoids the problem.
 
-------- Additional Comments From brian.cameron at ireland.sun.com  2003-08-13 10:40 -------
+------- Additional Comments From brian.cameron at sun.com  2003-08-13 10:40 -------
 Created an attachment (id=19184)
 patch suggteting different way to allocate array the works with Forte
 
 
 ------- Additional Comments From rbultje at ronald.bitfreak.net  2003-08-13 17:10 -------
 I've applied the pre-latest patch. I don't know whether making the