[Gstreamer-bugs] [Bug 135644] New - sys/oss/gstosssink.c does not build under NetBSD

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=135644

Changed by jmmv at menta.net.

--- shadow/135644	Fri Feb 27 18:01:53 2004
+++ shadow/135644.tmp.4340	Fri Feb 27 18:01:53 2004
@@ -0,0 +1,32 @@
+Bug#: 135644
+Product: GStreamer
+Version: HEAD CVS
+OS: NetBSD
+OS Details: 
+Status: NEW   
+Resolution: 
+Severity: normal
+Priority: Normal
+Component: gst-plugins
+AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
+ReportedBy: jmmv at menta.net               
+QAContact: gstreamer-maint at bugzilla.gnome.org
+TargetMilestone: HEAD
+URL: 
+Summary: sys/oss/gstosssink.c does not build under NetBSD
+
+The sys/oss/gstosssink.c file does not build under NetBSD, rendering 
+gst-plugins unbuildable out of the box.  There are basically two problems 
+in it: 
+ 
+First, the SNDCTL_DSP_GETODELAY ioctl does not exist in NetBSD.  I'm not 
+sure what it's supposed to do, and if it's really needed, but simply 
+avoiding its use seem to work fine (it has been patched this way for a 
+long time in pkgsrc, with no major problems, AFAICT).  I'm not aware of a 
+better solution, though. 
+ 
+Second, there is an ioctl(2) call that has only two arguments.  This is 
+wrong, since NetBSD expects three.  All other calls in the file are 
+correct, as they pass a null value as the third argument (they use a 
+literal 0, though I think they should use NULL).  So the solution is to 
+simply add a 0 as the third parameter to that call to make it work.