[Gstreamer-bugs] [Bug 117342] Changed - [PATCH] Change types for callbacks from G_TYPE_POINTER to more specific type (eg, GST_TYPE_ELEMENT, etc).

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=117342

Changed by ds at schleef.org.

--- shadow/117342	Sun Jan  4 22:54:49 2004
+++ shadow/117342.tmp.2912	Mon Jan  5 15:51:52 2004
@@ -1,13 +1,13 @@
 Bug#: 117342
 Product: GStreamer
 Version: HEAD CVS
 OS: All
 OS Details: 
-Status: NEW   
-Resolution: 
+Status: RESOLVED   
+Resolution: FIXED
 Severity: enhancement
 Priority: Normal
 Component: gstreamer (core)
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
 ReportedBy: brettk at frodo.dyn.gno.org               
 QAContact: gstreamer-maint at bugzilla.gnome.org
@@ -122,6 +122,16 @@
 that's just MHO).  However, there is support in the new Glib-Perl
 bindings to perform custom signal marshalling, so I should be able to
 write workarounds for those few cases.
 
 ------- Additional Comments From alexander.winston at comcast.net  2004-01-04 22:48 -------
 Adding the PATCH keyword.
+
+------- Additional Comments From ds at schleef.org  2004-01-05 15:51 -------
+I've reverted many of the changes from the core, because it causes
+bugs.  Signal type specifications are not for the wrapper's
+convenience, or for introspection, they are for properly marshalling a
+signal.  In particular, we almost always want to use POINTER for caps,
+since then the signal marshalling code doesn't copy the caps multiple
+times.  This means that the signal handler needs to treat the
+parameter as a 'const GstCaps *'.  I realize this makes wrappers
+difficult, but there's no way to make it easy in this case.