[Gstreamer-bugs] [Bug 144240] New: - [cdparanoia] sets wrong timestamps on buffers [patch]

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=144240
GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: [cdparanoia] sets wrong timestamps on buffers [patch]
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-maint at bugzilla.gnome.org
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-maint at bugzilla.gnome.org


cdparanoia sets consecutive timestamps on buffers (just for the sake of having 
a timestamp, it seems), which are just steadily increased and not affected by 
seeking, changing of tracks etc. 
 
This means that a query on the audiosink (or cdparanoia) will produce a time 
stamp that has no relation to the position currently being played back, which 
seems very undesirable for audio players etc. 
 
Instead, cdparanoia should set timestamps on buffers that represent the 
current position within the CD, ie. since the start of the CD, and send 
discont events on seeking/track changing IMHO. 
 
Patch attached. 
 
I realise the hack with g_object_{get|set}_qdata() is ugly, but it's the only 
sane way I could come up with to compensate for the missing padding. 
 
Tested with alsasink and artsdsink. 
 
Cheers 
 -Tim

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.