[Gstreamer-bugs] [Bug 135921] Changed - speexenc support won't compile with 1.1.x

[bugzilla-daemon at widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=135921

Changed by bugs at leroutier.net.

--- shadow/135921	Wed Mar 10 12:53:24 2004
+++ shadow/135921.tmp.21853	Fri Mar 12 08:17:03 2004
@@ -1,13 +1,13 @@
 Bug#: 135921
 Product: GStreamer
 Version: HEAD CVS
 OS: Linux
 OS Details: 
-Status: RESOLVED   
-Resolution: FIXED
+Status: REOPENED   
+Resolution: 
 Severity: normal
 Priority: Normal
 Component: gst-plugins
 AssignedTo: gstreamer-maint at bugzilla.gnome.org                            
 ReportedBy: bugs at leroutier.net               
 QAContact: gstreamer-maint at bugzilla.gnome.org
@@ -55,6 +55,44 @@
 http://bugzilla.gnome.org/show_bug.cgi?id=131270 contains a patch that
 would only compile speex plug-in if 1.0.x is found but not against 1.1
 
 ------- Additional Comments From bugs at leroutier.net  2004-03-10 12:53 -------
 would need to be worked out when speex 1.2.x would be out
 for the time beeing, only compile against speex 1.0.x
+
+------- Additional Comments From bugs at leroutier.net  2004-03-12 08:17 -------
+seems my speex version detection patch was not so good as it would
+still try to compile and fail with dev speex
+
+current is :
+
+dnl *** speex ***
+translit(dnm, m, l) AM_CONDITIONAL(USE_SPEEX, true)
+GST_CHECK_FEATURE(SPEEX, [speex plug-in], speex, [
+  PKG_CHECK_MODULES(SPEEX, speex >= 1.0 speex < 1.1, [
+    HAVE_SPEEX="yes"
+    AC_SUBST(SPEEX_CFLAGS)
+    AC_SUBST(SPEEX_LIBS)
+  ], [
+    GST_CHECK_LIBHEADER(SPEEX, speex, speex_bits_init, , speex.h,
+HAVE_SPEEX="yes" SPEEX_LIBS="-lspeex")
+    AC_SUBST(SPEEX_CFLAGS)
+    AC_SUBST(SPEEX_LIBS)
+  ])
+])
+
+should be :
+
+dnl *** speex ***
+translit(dnm, m, l) AM_CONDITIONAL(USE_SPEEX, true)
+GST_CHECK_FEATURE(SPEEX, [speex plug-in], speex, [
+  PKG_CHECK_MODULES(SPEEX, speex, [
+    HAVE_SPEEX="no"
+  ], [
+    GST_CHECK_LIBHEADER(SPEEX, speex, speex_bits_init, , speex.h,
+HAVE_SPEEX="yes" SPEEX_LIBS="-lspeex")
+    AC_SUBST(SPEEX_CFLAGS)
+    AC_SUBST(SPEEX_LIBS)
+  ])
+])
+
+as only speex 1.1 provides a .pc file.