[Gstreamer-bugs] [Bug 109857] Changed - GStreamer application development manual encourages incorrect g_error() usage
bugzilla-daemon at widget.gnome.org
bugzilla-daemon at widget.gnome.org
Sat Mar 13 09:09:39 PST 2004
Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.
http://bugzilla.gnome.org/show_bug.cgi?id=109857
Changed by t.i.m at zen.co.uk.
--- shadow/109857 Wed Feb 18 07:28:09 2004
+++ shadow/109857.tmp.31616 Sat Mar 13 12:09:39 2004
@@ -10,12 +10,13 @@
Component: documentation
AssignedTo: gstreamer-maint at bugzilla.gnome.org
ReportedBy: dilinger at voxel.net
QAContact: gstreamer-maint at bugzilla.gnome.org
TargetMilestone: 0.6.x
URL:
+Cc: t.i.m at zen.co.uk
Summary: GStreamer application development manual encourages incorrect g_error() usage
OtherBugsDependingOnThis: 120994
This has been bugging me while reading the documentation. A lot of the
examples have code like (taken from chap. 19):
@@ -57,6 +58,35 @@
}
I'll submit patches if you agree.
------- Additional Comments From in7y118 at public.uni-hamburg.de 2003-04-03 06:22 -------
Agreed, this is wrong behaviour. Patches are very welcome.
+
+------- Additional Comments From t.i.m at zen.co.uk 2004-03-13 12:09 -------
+Attached a patch that has better error handling.
+
+Other things that were fixed:
+
+ * added a handler for the pipeline's "error" signal
+ * renamed 'eof' handler
+ * try not to just call 'exit()' anywhere (makes it
+ harder to integrate the example with application
+ error handling etc.).
+
+
+Not sure if the error handling doesn't make the example
+unnecessarily messy.
+
+
+*** NOTE ***
+
+The example seems to be outdated and does not work. The 'colorspace'
+element fails with an assertion warning on every mpeg video I've
+tried. Maybe the example needs to be changed to use gst-ffmpeg
+plugins instead? (I could make it work with ffmpegcolorspace, but
+then the video would run twice as fast as the audio, with any
+scheduler, so I just left it as it is)
+
+Cheers
+-Tim
+
More information about the Gstreamer-bugs
mailing list