[gstreamer-bugs] [Bug 157548] New: [vorbisenc] premature and/or missing terminator to gst_caps_new_simple()

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=157548
GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: [vorbisenc] premature and/or missing terminator to
                    gst_caps_new_simple()
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net


This looks dodgy. Note the additional NULL after the "channels" property. I 
presume this is what's intended: 
 
diff -u -r1.63 vorbisenc.c 
--- ext/vorbis/vorbisenc.c      18 Oct 2004 13:55:48 -0000      1.63 
+++ ext/vorbis/vorbisenc.c      6 Nov 2004 22:21:14 -0000 
@@ -163,9 +163,11 @@ 
   return 
       gst_caps_new_simple ("audio/x-raw-float", 
       "rate", GST_TYPE_INT_RANGE, 8000, 50000, 
-      "channels", GST_TYPE_INT_RANGE, 1, 2, NULL, 
+      "channels", GST_TYPE_INT_RANGE, 1, 2, 
       "endianness", G_TYPE_INT, G_BYTE_ORDER, 
-      "width", G_TYPE_INT, 32, "buffer-frames", G_TYPE_INT, 0); 
+      "width", G_TYPE_INT, 32, 
+      "buffer-frames", G_TYPE_INT, 0, 
+      NULL); 
 } 
 
In any case, either the superfluous arguments should be removed, or the 
premature terminator removed and moved to the end where it's missing. 
 
Cheers  
 -Tim

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.