[gstreamer-bugs] [Bug 157986] New: [vorbisdec] fix warning when querying while draining

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=157986
GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: [vorbisdec] fix warning when querying while draining
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net


I occasionally get GST_IS_PAD() assertion failure warnings when querying my 
pipeline's audiosink. These are caused by vorbisdec calling gst_pad_query() on 
its sinkpad while the sinkpad is NULL. 
 
Patch attached. 
 
Cheers  
 -Tim 
 
Nov 11 15:51:55 <__tim> hmm, I'm getting GST_IS_PAD() failures in the call 
from vorbisdec.c, 248 occasionally when querying the audiosink 
Nov 11 15:52:47 <BBB> __tim, yeah, that's when we're draining 
Nov 11 15:52:57 <__tim> dec->sinkpad is NULL in that case.  So maybe it should 
be   if (!dec->sinkpad || !gst_pad_query()) ? 
Nov 11 15:53:34 <BBB> __tim, feel free to provide a patch that removes the 
warnings 
Nov 11 15:53:49 <BBB> because the query failures are not bad 
Nov 11 15:54:10 <__tim> well, if it's something known that needs fixing, then 
it's better to leave it there 
Nov 11 15:55:57 <BBB> __tim, it doesn't need fixing 
Nov 11 15:56:05 <BBB> __tim, or, rather, apart from the warning 
Nov 11 15:56:10 <BBB> it's just chain transition

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.