[gstreamer-bugs] [Bug 151877] New: - [PATCH] Fix bad casts in ximagesink.c

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=151877
GStreamer | gst-plugins | Ver: HEAD CVS

           Summary: [PATCH] Fix bad casts in ximagesink.c
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: nathanr at nathanr.net
         QAContact: gstreamer-bugs at lists.sourceforge.net


Another amd64 / 64 bit specific patch. In three places pointers are casted to
type (int). This should be using the GPOINTER_TO_INT() macro. Not doing so causes:

 gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../gst-libs -I../../gst-libs -pthread
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-I/home/nathanr/bin/gnome2-cvs/include/glib-2.0
-I/home/nathanr/bin/gnome2-cvs/lib64/glib-2.0/include
-I/home/nathanr/bin/gnome2-cvs/include/libxml2
-I/home/nathanr/bin/gnome2-cvs/include/gstreamer-0.8 -DGST_DISABLE_DEPRECATED
-Wall -Werror -I/usr/X11R6/include -g -O2 -MT libgstximagesink_la-ximagesink.lo
-MD -MP -MF .deps/libgstximagesink_la-ximagesink.Tpo -c ximagesink.c  -fPIC
-DPIC -o .libs/libgstximagesink_la-ximagesink.o
ximagesink.c: In function `gst_ximagesink_check_xshm_calls':
ximagesink.c:140: warning: cast from pointer to integer of different size
ximagesink.c: In function `gst_ximagesink_ximage_new':
ximagesink.c:217: warning: cast from pointer to integer of different size
ximagesink.c: In function `gst_ximagesink_ximage_destroy':
ximagesink.c:280: warning: cast from pointer to integer of different size
make[3]: *** [libgstximagesink_la-ximagesink.lo] Error 1
make[3]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins/sys/ximage'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins/sys'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathanr/download/gnome-cvs/gst-plugins'
make: *** [all] Error 2
*** error during stage build of gst-plugins: could not build module *** [70/91]

Fixed with patch I'll attach in a follow-up.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.