[gstreamer-bugs] [Bug 152091] - aspect-ratio fixes

[bugzilla-daemon at bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=152091
GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From rbultje at ronald.bitfreak.net  2004-09-07 14:33 -------
Created an attachment (id=31387)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=31387&action=view)
ximagesink PAR fixes.

retrieves pixel aspect ratio (PAR) from the xserver in _xcontext_get(). The
xcontext-caps is created in this function as well, including PAR. Due to user
configurability, a user can change the PAR and therefore, the final variable
containing the PAR is only intialized *after* xcontext_get() returns (actually,
it is being set right after calling xcontext_get() in change_state()). This
order is obviously wrong. You need to first set the PAR variable and then set
the caps. Attached patch fixes this. Similarly, the PAR is also free'ed in
xcontext_clear() rather than in _change_state(). No patch for xvimagesink is
provided because it handles PAR differently.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.