[gstreamer-bugs] [Bug 171735] add an interface to gst-core that allows multi child elements

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=171735
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Additional Comments From Ronald Bultje  2005-04-08 11:18 -------
nagging/layout:
* comments don't use // .., but /* .. */
* use code blocks, don't clump all lines together in a single function

functionality:
* it is not recursive, although that isn't all too hard. can you add that?
* adding this to core would at the very least imply that something in core
requires it (e.g. you want GstBin to implement this), or that it is incredibly
important and basic. I don't see either.
* I'd suggest to use GstObject, not GObject, as base type of contained items,
since you require names of childs. qdata is a gross hack.
* GstParent is not a very good name. It clashes with functions such as
gst_object_get_parent(). Maybe not literally, but functionally/understandingly.
Even if you implement this in GstBin, a child may still be contained in a bin
(which _get_parent() returns), but also be the child of a non-bin element
implementing this interface on his own.

on the idea itself:
* all this interface does, is provide ways to set properties of children through
a parent. That is interesting, but what is the practical need? What is your use
case? What exact problem do you want to solve through this? Can you give
examples? I don't see this beloning in core without at least gstbin implementing
this, and even then do I consider it questionable at the very least.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.