[gstreamer-bugs] [Bug 171735] add an interface to gst-core that allows multi child elements

bugzilla-daemon at bugzilla.gnome.org bugzilla-daemon at bugzilla.gnome.org
Fri Apr 15 02:51:53 PDT 2005


Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=171735
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Additional Comments From Ronald Bultje  2005-04-15 05:51 -------
OK, with the GstBin implementation, we're getting somewhere.

- The child-added/removed signals are unused and unimplemented, please either
implement or remove. Will this interface be used in a dynamic way?
- Is it just me, or is the get_child_count()/get_child_by_index() stuff a bit on
crack? You can do it in one GList* vfunc (get_child_list()) and implement the
rest as utility code. This makes implementations smaller.

As for the rest, I'm OK with this. One thing I'd appreciate, but not require, is
a testcase in which you use the GstBin implementation, i.e. have a bin called
bin0, add a child called fakesrc0 (and a fakesink0) and set the property
fakesrc0::num-buffers to, say, 10. Iterate pipeline and make sure that works.
this is both good for the testsuite and shows a practical use for this interface.

About naming: not too long please. :). Coders hate long names. I'm ok with
'GstPropertyProxy' or something like that ('GstPropertyDelegate', etc.). No need
to explicitely mention 'child', that is already obvious enough if you ask me; a
bin isn't called GstChildBin, is it? :).

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.




More information about the Gstreamer-bugs mailing list