[gstreamer-bugs] [Bug 323718] New: inapropriatly hardcoded <sys/soundcard.h>, should be autoconf'ed

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323718
 GStreamer | gst-plugins-good | Ver: 0.10.0

           Summary: inapropriatly hardcoded <sys/soundcard.h>, should be
                    autoconf'ed
           Product: GStreamer
           Version: 0.10.0
          Platform: Other
        OS/Version: OpenBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ben.pineau at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


Distribution/Version: 3.8

Several files on gst-plugins-good-0.10.0 relies on OSS headers being
<sys/soundcard.h>. This assumption is false on OpenBSD, where we
should rather #include <soundcard.h> (not "sys/soundcard.h"):

sys/oss/gstosshelper.c:#include <sys/soundcard.h>
sys/oss/gstossmixer.c:#include <sys/soundcard.h>
sys/oss/gstossmixertrack.c:#include <sys/soundcard.h>
sys/oss/gstosssink.c:#include <sys/soundcard.h>
sys/oss/gstosssrc.c:#include <sys/soundcard.h>

Indeed, those files won't compile as is on OpenBSD.

By the way, configure.ac has already "HAVE_OSS_INCLUDE_IN_ROOT" 
"HAVE_OSS_INCLUDE_IN_SYS" macros that works well here, and generate an
apropriate config.h we could rely on to include this header from the right 
path. On OpenBSD, it gives such a config.h:

/* Define if OSS includes are in / */
#define HAVE_OSS_INCLUDE_IN_ROOT

/* Define if OSS includes are in /sys/ */
/* #undef HAVE_OSS_INCLUDE_IN_SYS */

... and the opposite on my Debian GNU/Linux system.

This being on OpenBSD 3.8, released on November 2005, so don't be
fooled by configure.ac comment "dnl Some old BSD versions" ;).

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.