[gstreamer-bugs] [Bug 323878] New: missing <string.h> inclusion (for memset & FD_ZERO)

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323878
 GStreamer | gst-plugins-base | Ver: HEAD CVS

           Summary: missing <string.h> inclusion (for memset & FD_ZERO)
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ben.pineau at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


string.h is needed, else gsttcp won't compile on some platforms.

Index: gst/tcp/gsttcp.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcp.c,v
retrieving revision 1.21
diff -u -r1.21 gsttcp.c
--- gst/tcp/gsttcp.c    17 Oct 2005 13:46:22 -0000      1.21
+++ gst/tcp/gsttcp.c    12 Dec 2005 14:10:05 -0000
@@ -29,6 +29,7 @@
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <netdb.h>
+#include <string.h>  /* memset, in FD_ZERO macro */
 #include <unistd.h>
 #include <sys/ioctl.h>

Index: gst/tcp/gsttcpclientsink.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpclientsink.c,v
retrieving revision 1.16
diff -u -r1.16 gsttcpclientsink.c
--- gst/tcp/gsttcpclientsink.c  1 Dec 2005 01:21:49 -0000       1.16
+++ gst/tcp/gsttcpclientsink.c  12 Dec 2005 14:10:05 -0000
@@ -25,6 +25,7 @@
 #include <gst/dataprotocol/dataprotocol.h>
 #include "gsttcp.h"
 #include "gsttcpclientsink.h"
+#include <string.h>             /* memset */

 /* elementfactory information */
 static GstElementDetails gst_tcp_client_sink_details =
Index: gst/tcp/gsttcpserversink.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpserversink.c,v
retrieving revision 1.28
diff -u -r1.28 gsttcpserversink.c
--- gst/tcp/gsttcpserversink.c  6 Dec 2005 19:41:59 -0000       1.28
+++ gst/tcp/gsttcpserversink.c  12 Dec 2005 14:10:05 -0000
@@ -29,6 +29,7 @@
 #include "config.h"
 #endif
 #include <gst/gst-i18n-plugin.h>
+#include <string.h>             /* memset */

 #include <sys/ioctl.h>

Index: gst/tcp/gsttcpserversrc.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpserversrc.c,v
retrieving revision 1.27
diff -u -r1.27 gsttcpserversrc.c
--- gst/tcp/gsttcpserversrc.c   6 Dec 2005 19:41:59 -0000       1.27
+++ gst/tcp/gsttcpserversrc.c   12 Dec 2005 14:10:06 -0000
@@ -26,6 +26,7 @@
 #include <gst/gst-i18n-plugin.h>
 #include "gsttcp.h"
 #include "gsttcpserversrc.h"
+#include <string.h>             /* memset */
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <fcntl.h>

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.