[gstreamer-bugs] [Bug 323905] use return val of g_list_append

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323905
 GStreamer | gstreamer (core) | Ver: HEAD CVS

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55903|                            |commented-on
             Status|                            |
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From Tim-Philipp Müller  2005-12-12 18:24 -------
That's a nice catch, I wonder about one more thing though: we do

   current_list = g_list_append (current_list, buf);

and then return TRUE. Shouldn't that be

   buffer->store = g_list_append (current_list, buf);

or something like that? What's the point of doing the append if we don't store
it somewhere for later? (Don't have time to look through the code right now,
just bringing it up as something to double-check)

Cheers
 -Tim



------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.