[gstreamer-bugs] [Bug 324260] warning: ignoring return value of 'g_list_delete_link' (gcc 4.0.2)

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=324260
 GStreamer | gstreamer (core) | Ver: 0.8.11

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56066|0                           |1
        is obsolete|                            |
  Attachment #56067|                            |commented-on
             Status|                            |
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From Tim-Philipp Müller  2005-12-16 14:07 -------
Isn't the first chunk a bit dodgy anyway?

void
gst_spider_identity_unplug (GstSpiderIdentity * ident)
{
  GstSpider *spider = (GstSpider *) GST_OBJECT_PARENT (ident);
  GList *list;

  for (list = spider->links; list; list = list->next) {
    GstSpiderConnection *conn = list->data;

    if (conn->src == ident) {
      spider->links = g_list_delete_link (spider->links, list);
      gst_spider_link_destroy (conn);
    }
  }
  ident->plugged = FALSE;
}


so g_list_delete_link() removes the link 'list' from the list and frees it, but
then the loop continues with list = list->next accessing the already free'd link
node, no?

Maybe there should be an additional list = spider->links; or  break;  in there?



------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.