[gstreamer-bugs] [Bug 323693] [PATCH] [lame] accept track-count tag

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=323693
 GStreamer | gst-plugins-ugly | Ver: HEAD CVS


malsyned at uofr.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55832|0                           |1
        is obsolete|                            |




------- Comment #4 from malsyned at uofr.net  2006-01-01 00:26 UTC -------
Created an attachment (id=56618)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=56618&action=view)
Re-entrant version of the previous patch

This new patch should aleviate any concerns about re-entrancy.  As a trade-off,
it has to do a lot more wrapping of functions and data structures, as mentioned
in passing at the end of my previous post.

There is one note to the maintainer (grep MAINTAINER: gstlame.c) because the
intentions behind one line of code weren't clear, and I had to try to map those
intentions onto my modified code.  I think I chose correctly, but I left the
alternate interpretation in a comment, just in case.

Also, I've been brainwashed by Paul Graham into loving macros, and I think that
my use of the DEFINE_GST_LAME_ID3TAG_WRAPPER macro makes the code more concise,
readable, and comprehensible.  If this is not the consensus view, however, I'd
be happy to do the grunt work of hand-expanding all the macro invocations and
then posting a new patch.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.