[gstreamer-bugs] [Bug 306233] Porting work on videotestsrc, using GstBaseSrc

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=306233
 GStreamer | gst-plugins | Ver: HEAD CVS

wingo at pobox.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1
            Summary|Porting work on             |Porting work on
                   |videotestsrc,  using        |videotestsrc,  using
                   |GstBaseSrc                  |GstBaseSrc



------- Additional Comments From wingo at pobox.com  2005-07-14 14:22 -------
Hi Lipeng,

Wow, we need to look at these bugs more. Also, a little poking doesn't hurt --
let us know if a patch sits around for too long.

Now, some comments. Your patch is a bit too big, difficult to see the actual
changes. To fix this next time,

1) Try not to introduce whitespace / indentation changes. If your editor makes
this difficult, run gst-indent (from core gstreamer, gstreamer/tools/gst-indent)
on the code before diffing.

2) Don't change things randomly -- or if you do, include those style fixes in a
separate patch. e.g.

-gst_videotestsrc_base_init (gpointer g_class)
+gst_videotestsrc_base_init (GstVideotestsrcClass * klass)

does not need to be in this patch.

+  outbuf = gst_pad_alloc_buffer (pad, GST_BUFFER_OFFSET_NONE, newsize,
GST_RPAD_CAPS (pad));
+
+  if (GST_BUFFER_CAPS (outbuf) != GST_PAD_CAPS (pad)) {

gst_pad_alloc_buffer does a setcaps already. Also, by now its signature has
changed, so as to return a FlowReturn.

Otherwise the patch is fine, if updated to the latest API. I'll probably go
ahead and do that now, because I need to ping ds for some other
videotestsrc-related things.


------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.