[gstreamer-bugs] [Bug 308335] [PATCH] ffmpeg postprocessing plugins

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=308335
 GStreamer | gst-ffmpeg | Ver: HEAD CVS

Ronald Bultje changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48019|                            |accepted-commit_now
             Status|                            |
  Attachment #48034|                            |accepted-commit_now
             Status|                            |
   Target Milestone|HEAD                        |0.8.6



------- Additional Comments From Ronald Bultje  2005-06-20 08:59 -------
+  /*
+    TODO : We need to find out what CPU flags we have in order to set
+    MMX/MMX2/3DNOW optimizations
+  */

That doesn't look good, since it is implemented. Please remove.

+/*   inplane[0] = GST_BUFFER_DATA(in); */
+/*   inplane[1] = inplane[0] + postproc->ysize; */
+/*   inplane[2] = inplane[1] + postproc->usize; */

Since you don't use the inplane, can you remove it?

Apart from those two minor issues, it looks good. Please apply. Please run it
through gst-indent before applying, I'm trying to keep style in the .c files
consistent (and am faling hopelessly :) ).

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.