[gstreamer-bugs] [Bug 308633] Matroska muxer always fails

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=308633
 GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From Michal Benes  2005-06-22 11:23 -------
I have found the source of the bug:
gst_matroska_mux_prepare_data (mux) is called in the _loop function
before
gst_matroska_mux_start (mux);

The problem is that gst_matroska_mux_prepare_data assumes that
mux->sink[i].track->num is > 0 for at least one sink pad but the track nums are
set to valid numbers only in gst_matroska_mux_start.

One solution would be to remove the test 
mux->sink[i].track->num > 0
from 
gst_matroska_mux_prepare_data
This should be OK since there is still test 
GST_PAD_IS_USABLE (mux->sink[i].track->pad) 
and all usable pads will get track->num later in gst_matroska_mux_start

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.