[gstreamer-bugs] [Bug 169396] clock api broken by GstVideoSink

bugzilla-daemon at bugzilla.gnome.org bugzilla-daemon at bugzilla.gnome.org
Thu Mar 10 10:58:53 PST 2005


Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=169396
 GStreamer | gst-plugins | Ver: 0.8.8





------- Additional Comments From Ronald Bultje  2005-03-10 13:58 -------
You should never call the videosink implementation directly. It is intended to
be a virtual function. Compare other functions that are virutally overrideable.
They all are called class->this_name, the calling function (what apps call) is
gst_something_this_name, the default implementation (if any) is called
gst_something_this_name_func and subclass implementations are called
gst_subclass_this_name. This may be a bit weird, but we've done it for years and
it makes a lot of sense if yuo think about it.

at best, it's badly documented, and I'll do better in 0.9. Also, the actions in
gst_element_set_clock() should indeed be done in the default virtual function
implementation. Those are all imperfections, which I will fix in 0.9 (where we
rewrite all this), but not now. Hence the 'NOBUG' mark.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.




More information about the Gstreamer-bugs mailing list