[gstreamer-bugs] [Bug 171400] New: mmapsize property on gstfilesrc borked.

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=171400
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: mmapsize property on gstfilesrc borked.
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tristan.van.berkom at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


Hmmm, just started looking through the source to start hacking
my very own gstreamer element, and I found this broken logic
in the first source file I opened, call it beginners luck ;-)

I'm sure that this:
=====================
if ((src->mapsize % src->pagesize) == 0) {
  src->mapsize = g_value_get_ulong (value);
} else {
   ...
}
=====================
Was meant to test that the *new* mapsize be a multiple of pagesize;
not to only allow changing the mmap size if the current mmap size
is valid.

patch comming...

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.