[gstreamer-bugs] [Bug 161661] [PATCH] screenshots via gstreamer

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=161661
 GStreamer | gst-plugins | Ver: HEAD CVS





------- Additional Comments From Ronald Bultje  2005-03-25 12:59 -------
Hi,

I had a look today and was fairly amused by this plugin. It's a nice hack,
really. Also, we've actually wanted this for a long time already. Although I
mostly agree with Dave's comments (this could be done a lot nicer ladieda), we
simply don't have anything like this right now, and it *is* really very useful
(for those of us not running weird x server thingies). We could always improve
it later on.

I'm leaning towards accepting this for now. A few things do need work, mostly
small nitpicks:
* the enum GstScreenshotsrcPattern needs to die, because it is unused.
* so does the num-buffers, or at least the default needs to be to turn it off.
EOS should be handled by a managing bin (see gnome-sound-recorder, cupid, ...).
* ideally, you'd include a small script showing how to capture a theora file at
1 FPS or so.
* get_type() is not const.
* screenshot-utils.[ch] misses a copyright header.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.