[gstreamer-bugs] [Bug 169391] [rtpL16enc/parse] don't work (patch attached)

[bugzilla-daemon at bugzilla.gnome.org]

Please DO NOT reply to this by email. All additional comments should be made in
the comments box of this bug report.

 http://bugzilla.gnome.org/show_bug.cgi?id=169391
 GStreamer | gst-plugins | Ver: 0.8.7





------- Additional Comments From Zeeshan Ali  2005-03-27 15:13 -------
Finally, I was able to reviewe the patch. Although most of the code seems quite
cool, except for a few concerns:

gstrtpL16enc.c:

* Why have props for sample_rate, payload_type, rtpmap and the number of
channels when we get/derive these values from the caps?

* In the following code, you seem to doing some kind of mutual-recursion:

    this_samples = this_packet_len / 2 / rtpL16enc->channels;
    /* if space_for_samples not right for a fixed number of samples, adjust! */
    this_packet_len = 2 * rtpL16enc->channels * this_samples;

As the value of 'this_packet_len' shall remain to be the same after the
execution of the last statement.

gstrtpL16parse.c:

* The number of channels can be detected by the payload_type so there is no need
to have a seperate prop. for it. is it?

Now regarding wether to have the byte-swaping code inside the plugin or not:
IMHO it should be inside the rtp elements.

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.