[gstreamer-bugs] [Bug 316856] New: GstBin does state changes in wrong order sometimes

[GStreamer (bugzilla.gnome.org)]

Do not reply to this email.  You can add comments to this bug at
 http://bugzilla.gnome.org/show_bug.cgi?id=316856
 GStreamer | gstreamer (core) | Ver: HEAD CVS

           Summary: GstBin does state changes in wrong order sometimes
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: High
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: t.i.m at zen.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


Take a pipeline like:

  filesrc ! flacdec ! alsasink

This will fail with a pad activation assertion issue, but the underlying problem
is that GstBin propagates the state changes in the wrong order.

Currently, GstBin does:

  sink       null => ready
  filesrc    null => ready
  flacdec    null => ready
  filesrc    ready => ready
  pipeline   null => ready

whereas it should do:

  sink       null => ready
  flacdec    null => ready
  filesrc    null => ready
  pipeline   null => ready


The attached patch fixes the problem for the above case. Would be nice if
someone more familiar with state changes and the different scenarios involved
could take a look at it before I commit it. Maybe there is more that needs to be
done for more complex scenarios.

Cheers
 -Tim

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.