[gstreamer-bugs] [Bug 317630] New: cdparanoia seems to read one segment too much

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=317630
 GStreamer | gst-plugins | Ver: 0.8.10

           Summary: cdparanoia seems to read one segment too much
           Product: GStreamer
           Version: 0.8.10
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lool+gnome at via.ecp.fr
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: all-bugs at bugzilla.gnome.org


Hi,

Gustavo Noronha Silva reported in Debian bug http://bugs.debian.org/330954 that
gnome-cd locks at the end of the last track when using cdparanoia.

He proposes the following patch fixing the issue for him:
--- ext/cdparanoia/gstcdparanoia.c~     2005-08-29 11:50:49.000000000 +0000
+++ ext/cdparanoia/gstcdparanoia.c      2005-09-30 15:53:19.155742291 +0000
@@ -553,7 +553,7 @@
   }
 
   /* stop things apropriatly */
-  if (src->cur_sector > src->segment_end_sector) {
+  if (src->cur_sector >= src->segment_end_sector) {
     GST_DEBUG ("setting EOS");
 
     buf = GST_BUFFER (gst_event_new (GST_EVENT_EOS));

I'm going to attach his diff as a real file.

Cheers,

------- You are receiving this mail because: -------
You are the assignee for the bug.
You are the QA contact for the bug.