[gstreamer-bugs] [Bug 350044] [dvdsubdec] outputs buffers with negative durations

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=350044
 GStreamer | gst-plugins-ugly | Ver: 0.10.x


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |343348
              nThis|                            |
  Attachment #70253|none                        |committed
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|DVD subtitles (vobsub) are  |[dvdsubdec] outputs buffers
                   |broken in gstreamer 0.10    |with negative durations
   Target Milestone|HEAD                        |0.10.4




------- Comment #2 from Tim-Philipp Müller  2006-08-07 10:33 UTC -------
Nice catch!

http://webcvs.freedesktop.org/gstreamer/gstreamer/gst/gstclock.h?r1=1.42&r2=1.43

seems related ;)

Committed to CVS:

  2006-08-07  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Frédéric Riss  <frederic.riss at gmail com>

        * gst/dvdsub/gstdvdsubdec.c: (gst_send_subtitle_frame):
          Don't set negative durations on outgoing buffers (#350044),
          which happens when you use macros that got changed during
          the last unstable cycle because they were thought not to
          be used anywhere.


As for VOB subtitle support in totem, that mostly needs implementing in
playbin. There needs to be an image mixer (but preferably not videomixer, since
we really don't want to convert the input video stream into AYUV just to blit
the subtitles on top and then convert back again) etc.

Also, mpegdemux/dvddemux need to send newsegment updates as events to fill in
the gaps, and the videomixer needs to handle this properly.

I've got such a mixer element somewhere (but then got distracted with other
things), will try to dig it out again and see if it works now that the
durations are fixed.

(changed bug description since that is what will appear in the module's release
notes; feel free to open a new bug against -base for the playbin-related work
that needs to be done)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.