[gstreamer-bugs] [Bug 349015] [sunaudio] open source with O_NONBLOCK

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=349015
 GStreamer | gst-plugins-good | Ver: HEAD CVS





------- Comment #7 from Brian Cameron  2006-08-11 06:05 UTC -------

Jerry, it doesn't seem like you have done any of the research that was pointed
out by the engineers who have reviewed your patch.

Some people have suggested that NONBLOCK may be better, if we can get it
working.  Just because we notice lost data when we have NONBLOCK does not mean
that the NONBLOCK flag is the problem.  As I mentioned in my previous comment,
we need to test to see if NONBLOCK works if we manage EINTR/EAGAIN making the
read
function look something like this

{
   do {
      ret = read (sunaudiosrc->fd, data, length);
   while (ret == EINTR || ret == EAGAIN);

   return ret
}

Does NONBLOCK work if you try something like this?  

In other words, the patch you provided may be a good workaround to make things
work for now, but might not really be the best solution.

Also, I'm not sure that the MIXER ioctl belongs in the source.  Note that the
source plugin calls gst_sunaudiomixer_ctrl_new, which calls
gst_sunaudiomixer_ctrl_open.  Might be better to put this ioctl in the mixer
code.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.