[gstreamer-bugs] [Bug 350935] API: add GST_TAG_EXTENDED_COMMENT

GStreamer (bugzilla.gnome.org) bugzilla-daemon at bugzilla.gnome.org
Sat Aug 12 03:01:52 PDT 2006


Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=350935
 GStreamer | gstreamer (core) | Ver: HEAD CVS





------- Comment #3 from Tim-Philipp Müller  2006-08-12 10:01 UTC -------
> > (sneakily changes GST_TAG_COMMENT's merge function to something more sensible
> > too)
> 
> What's the semantic difference between those two functions?  Does it mean that
> only the first comment tag is used rather than using all of them with commas
> separating them? 

The merge function determines what happens when you use gst_tag_list_get_xyz(),
as opposed to gst_tag_List_get_xyz_index (..., 0), on a taglist that contains
multiple tags. If you have a list with

 GST_TAG_COMMENT="This song sucks"
 GST_TAG_COMMENT="This song rocks"

then gst_tag_list_get_string (list, GST_TAG_COMMENT) will currently
automatically concatenate the two comments into a combined string separated by
a comma, ie. you get "This song sucks, this song rocks" returned; changing the
merge function to merge_use_first will make it return only the first string and
leave it to the application to look for other comments.

I think this makes more sense than merge_with_comma (since concatenated comment
strings rarely look as nice as the one above), but I'm not married to it. Just
came across it as I added this tag.

What do you think?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list