[gstreamer-bugs] [Bug 351768] Unwanted concurent buffer modifications

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=351768
 GStreamer | gstreamer (core) | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com




------- Comment #2 from Jan Schmidt  2006-08-17 16:00 UTC -------
You're quite right. Ordinarily, creating a subbuffer sets the READONLY flag,
but make_metadata_writable is overwriting it by copying the flags directly off
the parent buffer.

In fact, make_metadata_writable could check whether the buffer is writable
(using gst_buffer_is_writable) before subbuffering and set the READONLY flag on
the subbuffer accordingly - if we subbuffer a writable buffer and then drop the
reference, the child is still writable, because there will still only be one
reference to the parent.

Also, yes, I think DURATION, OFFSET_END and CAPS should be copied too. This
could possibly be done as a generic thing if making a subbuffer that is the
entire original buffer.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.