[gstreamer-bugs] [Bug 382766] New: gst_gconf_get_default_audio_sink broke API/ABI in 0.10.3

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=382766

  GStreamer | gst-plugins-good | Ver: 0.10.3

           Summary: gst_gconf_get_default_audio_sink broke API/ABI in 0.10.3
           Product: GStreamer
           Version: 0.10.3
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: abockover at novell.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


gst-plugins-good 0.10.2: gst_gconf_get_default_audio_sink(void)
gst-plugins-good 0.10.3: gst_gconf_get_default_audio_sink(int)

We can now not use this function. Luckily in Banshee I was still using the
element factory to get a gconfaudiosink, but looking around at different
players, I see that RhythmBox does use gst_gconf_get_default_audio_sink() in
its GStreamer backend, so problems are to be expected:

http://cvs.gnome.org/viewcvs/rhythmbox/backends/gstreamer/rb-player-gst.c?rev=1.75&view=markup

As for the revision introducing the API/ABI breakage:
http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/ext/gconf/gconf.c?sortby=log&r1=1.5&r2=1.6&pathrev=RELEASE-0_10_3

Looks like a patch from Jürg Billeter <j at bitron.ch>.

API/ABI should not be broken. The introduction of the "profile" property on the
element itself is fine, and much welcomed. Applications whishing to use it can
query the element's class to see if the property exists, and set if it does.

An alternate function should have been introduced instead of breaking the
existing one, something like gst_gconf_get_default_audio_sink_with_profile(int
profile)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email