[gstreamer-bugs] [Bug 383726] New: [audiopanorama] only transforms half of the samples in float mode

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=383726

  GStreamer | gst-plugins-good | Ver: HEAD CVS

           Summary: [audiopanorama] only transforms half of the samples in
                    float mode
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: slomo at ubuntu.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


Hi,
currently audiopanorama only transforms one half of the samples when working in
float mode. It can accept 16 bit int or 32 bit float samples, the num_samples
calculation in the transform function only assumes 16 bit int samples.

Attached is a patch to fix this (by adding a new instance variable width). I
decided to fix it this way because getting caps of the buffer, reading the
structure of the caps and reading the width element of it would be unnecessary
overhead in the transform function and it shouldn't change without calling the
caps function anyway.

Bye


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email