[gstreamer-bugs] [Bug 354174] [PATCH] add REAL support by using the proprietary drivers

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=354174

  GStreamer | gst-plugins-ugly | Ver: HEAD CVS


René Stadler changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail at renestadler.de




------- Comment #15 from René Stadler  2006-12-08 21:46 UTC -------
I cannot find a single file that this element will decode.  The error is
always:

Could not decode buffer: 2147942487

According to MPlayer reverse engineering docs this corresponds to E_INVALIDREG.

Aside from that, some things to note:

Such error code/developer information belongs in the debug message part you
pass to GST_ELEMENT_ERROR.  Just use (NULL) for the message (which will get
substituted by the standard message for that error).

Another thing that caught my eye is this:
 result = dec->transform (
        (gchar *) gst_adapter_take (dec->adapter, dec->length),
        (gchar *) GST_BUFFER_DATA (out),
        tin, tout, dec->context);

I somehow doubt that the proprietary driver calls g_free on the first argument,
therefore the element leaks _all_ data that is passed in!  You can also get rid
of all that casting to gchar * by defining the prototype for the transform
function to use data arguments of type guint8 *, which makes more sense (this
is why GstAdapter and GstBuffer use this type).

I must say that you make it relatively hard for people to try out your
elements.  You should provide a single patch file that sets up the full
autotool integration alongside the source.  This way, people only need to grab
a single file and can fully install the plugin into a checked out tree with
just a single command.

P.S.: This should be against gst-plugins-bad, regardless of the fact that the
final destination is doubtlessly -ugly.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email