[gstreamer-bugs] [Bug 378184] g-s-p crash due to incorrect free from do_toggle_element

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=378184

  GStreamer | gst-plugins-good | Ver: 0.10.4


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78117|none                        |committed
               Flag|                            |
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.5




------- Comment #4 from Tim-Philipp Müller  2006-12-11 11:44 UTC -------
Ah, I thought maybe you could reproduce it. I think this fixes it, I can't see
anything wrong with the g_free stuff (it's not really thread-safe, but this
shouldn't be an issue here since the gconf notify is always called from the
same thread as the app here).

 2006-12-11  Tim-Philipp Müller  <tim at centricular dot net>

       * ext/gconf/gstgconfaudiosrc.c: (gst_gconf_audio_src_init),
       (gst_gconf_audio_src_dispose), (do_toggle_element):
       * ext/gconf/gstgconfaudiosrc.h:
         Remove gconf notify hook when the gconfaudiosrc element is
         destroyed, otherwise the callback may be called on an
         already-destroyed instance and bad things happen. Should fix
         #378184.
         Also ignore gconf key changes when the source is already running.




-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email