[gstreamer-bugs] [Bug 380199] [matroskademux] Wrong framerate conversion

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=380199

  GStreamer | gst-plugins-good | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77300|0                           |1
        is obsolete|                            |




------- Comment #2 from Tim-Philipp Müller  2006-12-11 13:02 UTC -------
Created an attachment (id=78127)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=78127&action=view)
alternative patch for default framerate in caps

Does this patch also make things work fine for you?

I think it's better to save the float value we extract and re-use it here than
to do two 1/N calculations including uint64/double conversion. Also, the reason
for the gst_guint64_to_gdouble() is that some compilers (MSVC) apparently can't
convert double <=> guint64 by just casting, so it needs to be used on
context->default_duration not GST_SECOND here (GST_SECOND still fits into an
int IIRC).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email