[gstreamer-bugs] [Bug 377306] gnome-volume-control does not localize the label.

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=377306

  GStreamer | gst-plugins-base | Ver: HEAD CVS





------- Comment #8 from Tim-Philipp Müller  2006-12-11 15:13 UTC -------
> > - where in the code does gnome-volume-control compare mixer track
> >   labels with device names?
> 
> gnome-media/gst-mixer/src/track.c: (snip)

Ah, I see. The code there just tries to guess an icon for the track from the
mixer label. This already fails with alsamixer now if the label is translated
and doesn't match; the patch to translate the alsamixer labels in GStreamer was
committed by the primary gnome-volume-control maintainer as well, so I'm sure
it's not a problem, and it only affects the icon anyway.


> The track->label is the gst-plugins-good and pix[i].label is gst-mixer.
> Do you think we also should i18n pix[i].label?

No, I don't think that's a good idea (since chances are that the translation in
gnome-volume-control doesn't match the one in the GStreamer mixer
implementation later on).

IMHO, we should always translate track->label as we do now in alsamixer already
and think about a way to provide the non-translated info to
gnome-volume-control in some form (ie. possibly adding a
track->untranslated_label or so, if that's possible without breaking ABI
compatibility, otherwise we could always add a
gst_mixer_track_get_untranslated_device() or _get_icon_hint() or whatever
function).

On a side note, I don't entirely understand the point of the fill_labels()
function in gstsunaudiomixertrack.c (cases[x].given is never used, and why not
just move the array of N_()'ed strings into gst_sunaudiomixer_track_new()
directly?) - am I missing something? :)


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email