[gstreamer-bugs] [Bug 388050] [PATCH] simplification of the neon plugin

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=388050

  GStreamer | gst-plugins-bad | Ver: HEAD CVS





------- Comment #2 from Tim-Philipp Müller  2006-12-21 09:47 UTC -------
Could you do a short summary of the changes and their purpose? It looks to like
it's more than just a clean-up.

I am not sure the typefinding addition is a good idea in this case (sources are
special IMHO). GstBaseSrc has a "typefind" property already, so the typefinding
should be put into GstBaseSrc if it's needed (but I still don't think this is a
good idea for push sources).

Typefinding the first buffer and setting caps makes typefinding depend on the
configured buffer size (or the length of the first chunk of data we receive)
and the accuracy of typefinding decreases considerably with smaller buffer
sizes. Why not just let typefind and/or other elements that do typefinding do
their job?


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email