[gstreamer-bugs] [Bug 390673] videocrop check fails in iurt build bot

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=390673

  GStreamer | gst-plugins-bad | Ver: 0.10.x


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |NOTGNOME
   Target Milestone|HEAD                        |NONE




------- Comment #5 from Tim-Philipp Müller  2006-12-30 12:58 UTC -------
> The build system will only install packages that are in
> BuildRequires, gst-plugins-base was not (only the -devel part of it).
> Maybe the configure script should check for the videotestsrc element,
> what do you think?

Not really sure, since

 a) many GStreamer developers feel checking for elements
    in configure scripts is generally not useful, because it
    has to be done again at runtime anyway

 b) most people never run 'make check'

 c) if we do add the check, other people that never actually run
    'make check' as part of their build/buildbot setup will complain
    about the unnecessary build dependency ;)

 d) arguably, we only really ship source tarballs as a whole, so by
    implication the check for the -base headers should be sufficient
    (and everything else would be either a packaging issue or someone
    mixing sources and packages who then should better know what
    she's doing).


I think it's best to just make the failure cases a bit more verbose so that
it's more obvious what's missing:


 2006-12-30  Tim-Philipp Müller  <tim at centricular dot net>

        * tests/check/elements/videocrop.c: (GST_START_TEST),
        (videocrop_test_cropping_init_context):
          When we can't create an element needed for the test, print a message
          detailing which element it actually is that's missing (#390673).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email