[gstreamer-bugs] [Bug 330796] New: video4linux building bugsquash

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=330796
 GStreamer | gst-plugins | Ver: 0.8.11

           Summary: video4linux building bugsquash
           Product: GStreamer
           Version: 0.8.11
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: Normal
         Component: gst-plugins
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: bernard at brenda-arkle.demon.co.uk
         QAContact: gstreamer-bugs at lists.sourceforge.net
                CC: bernard at brenda-arkle.demon.co.uk
     GNOME version: Unspecified
   GNOME milestone: Unspecified


*** PATCH KNOWN, WILL FOLLOW ***

Some combination or other of missing or disabled debug options can lead to
the video4linux plugin being compiled WITHOUT the macro GST_DISABLE_GST_DEBUG
being defined (it happened to me).
The debugging function gst_v4lsrc_palette_name() is still unconditionally
included in the code, but it tries to refer to the array v4l_palette_name[], 
which is conditionally excluded.

This was in the code last time I built the plugins, several releases ago,
though I was too shy to submit a patch.  I'm a bit boggled that nobody
else has run into it!  My 'configure' options are really not strange at all.

The patch comes next.
I've simply returned a dummy name if the array isn't
available.  This is certainly safe, if a bit lazy on my part (ideally I
should check whether I really need the function at all).  However, the
cost of retaining the useless stub is so tiny that I can't be bothered
to see whether removing it breaks anything.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.