[gstreamer-bugs] [Bug 326864] New: Wavparse, pad conversion miscalculates for some formats

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=326864
 GStreamer | gst-plugins-good | Ver: 0.10.0

           Summary: Wavparse, pad conversion miscalculates for some formats
           Product: GStreamer
           Version: 0.10.0
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: ext-tommi.myohanen at nokia.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


There seems to be problems with e.g. IMA-ADPCM format when converting from
GST_FORMAT_TIME to GST_FORMAT_BYTES, the dest_value gets wrong values due to
blockalign.
This patch should fix the problem.

--- gstwavparse.c.orig  2005-12-28 16:04:44.000000000 +0200
+++ gstwavparse.c       2005-12-28 16:21:17.000000000 +0200
@@ -1104,8 +1104,8 @@
       switch (*dest_format) {
         case GST_FORMAT_BYTES:
           /* make sure we end up on a sample boundary */
-          *dest_value =
-              (src_value * wavparse->rate / GST_SECOND) *
wavparse->blockalign;
+          *dest_value = src_value * wavparse->bps / GST_SECOND;
+          *dest_value -= *dest_value % wavparse->blockalign;
           break;
         case GST_FORMAT_DEFAULT:
           *dest_value = src_value * wavparse->rate / GST_SECOND;


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.