[gstreamer-bugs] [Bug 326734] [mad] Add 24-bit output support
GStreamer (bugzilla.gnome.org)
bugzilla-daemon at bugzilla.gnome.org
Sat Jan 14 13:08:43 PST 2006
Do not reply to this via email (we are currently unable to handle email
responses and they get discarded). You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=326734
GStreamer | gst-plugins-ugly | Ver: HEAD CVS
Jan Schmidt changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |thaytan at mad.scientist.com
------- Comment #10 from Jan Schmidt 2006-01-14 21:08 UTC -------
Patches look ok from a brief read, except this bit looks strange:
- bytes_per_sample = MAD_NCHANNELS (&mad->frame.header) << 1;
+ bytes_per_sample = MAD_NCHANNELS (&mad->frame.header) * 32;
Also, I'm not sure whether we need permission for the 'scale code taken from
MAD'. Technically, the GStreamer plugin itself is LGPL, where mad code itself
is GPL.
--
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list