[gstreamer-bugs] [Bug 347304] Massive leaks with xvimagesink

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=347304
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Jan Schmidt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gstreamer-                  |thaytan at mad.scientist.com
                   |bugs at lists.sourceforge.net  |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




------- Comment #2 from Jan Schmidt  2006-07-12 16:48 UTC -------
Created an attachment (id=68825)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=68825&action=view)
Patch

So, it turns out that xvimagesink was _never_ correctly releasing
buffer_alloced buffers, resulting in leaking all the shared memory segments.

fixing that exposed a bug where buffers returned to the sink at the exact
moment it was shutting down might remain in the buffer pool, and cause crashes
later when the sink is reused. This patch fixes that by using locks to protect
the XContext and the 'running' variable, so that the buffer_finalize method
isn't racy with respect to what the sink is doing.

Patch fixes the same problem in ximagesink. It also fixes a not-so-small caps
leak in decodebin exposed by valgrind.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.