[gstreamer-bugs] [Bug 345188] [alsa] can't handle more than 8 channels

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=345188
 GStreamer | gst-plugins-base | Ver: HEAD CVS


Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69165|0                           |1
        is obsolete|                            |




------- Comment #17 from Tim-Philipp Müller  2006-07-21 10:18 UTC -------
Created an attachment (id=69313)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=69313&action=view)
new patch

Indeed, nice catch, thanks. Updated the patch for that.

and it should also be

   /* everything else (4, 6, 8 channels) needs a channel layout */
-  for (c = 4; c <= 8; c += 2) {
+  for (c = MAX (4, min_chans); c <= 8; c += 2) {
   ...
   }

I presume.

The patch also changes the channel position validity check in multichannel.c so
that it is no longer allowed to have only some channel positions UNDEFINED.
Either all are UNDEFINED or all are defined, but mixing UNDEFINED with other
channel positions isn't allowed. I think that makes sense (and we can still
permit additional possibilities later if it seems necessary, but we can't
really change it to be stricter).


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.