[gstreamer-bugs] [Bug 348644] New: [id3demux] Gets the wrong part of binary blob for ID3 v2.2 tags

[GStreamer (bugzilla.gnome.org)]

Do not reply to this via email (we are currently unable to handle email
responses and they get discarded).  You can add comments to this bug at
http://bugzilla.gnome.org/show_bug.cgi?id=348644
 GStreamer | gst-plugins-good | Ver: HEAD CVS

           Summary: [id3demux] Gets the wrong part of binary blob for ID3
                    v2.2 tags
           Product: GStreamer
           Version: HEAD CVS
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: alexl at users.sourceforge.net
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


There is a problem in id3demux when trying to convert an IDv2.2 tag to IDv2.4
using the recent id3demux in CVS in conjunction with patch #69560 on bug
#334375

It apears to be getting the last 3 characters of the previous blob, e.g. 

In the attached sample of a file, the hexdump contains this:

TP1....Boards Of Canada.TCM..+.marcus eoin/michael sandison (warp music).TAL

When attempting to convert the non-gst supported TCM (composer) into a blob, it
uses creates a mime type of: "application/x-gst-id3v2-ada

Note the "ada" is the last 3 chars of Canada, which leads me to expect that it
it is offset somehow, later on in id3v2mux when injecting this (using that
patch) it creates a segfault.

GST_DEBUG="id3demux:5,id3v2mux:5" GST_PLUGIN_PATH=/usr/local/lib/gstreamer-0.10
gst-launch filesrc location=test4.mp3 ! id3demux ! id3v2mux ! filesink
location=test4-retagged.mp3

LOG   (0x8fa09d8 - 0:00:00.354571000)             id3demux(22381)
id3tags.c(462):id3demux_id3v2_frames_to_tag_list: Frame @ 37 (0x25) id TPE1
size 18, next=61 (0x3d) obsolete=0
LOG   (0x8fa09d8 - 0:00:00.354722000)             id3demux(22381)
id3v2frames.c(260):parse_text_identification_frame: Read 1 fields from Text ID
frame of size 17. First is 'Boards Of Canada'
LOG   (0x8fa09d8 - 0:00:00.354923000)             id3demux(22381)
id3tags.c(473):id3demux_id3v2_frames_to_tag_list: Extracted frame with id TPE1
LOG   (0x8fa09d8 - 0:00:00.355060000)             id3demux(22381)
id3tags.c(462):id3demux_id3v2_frames_to_tag_list: Frame @ 61 (0x3d) id TCOM
size 43, next=110 (0x6e) obsolete=0
LOG   (0x8fa09d8 - 0:00:00.355197000)             id3demux(22381)
id3tags.c(475):id3demux_id3v2_frames_to_tag_list: Failed to extract frame with
id TCOM
LOG   (0x8fa09d8 - 0:00:00.355342000)             id3demux(22381)
id3tags.c(353):id3demux_add_id3v2_frame_blob_to_taglist: Making a binary blob
with application/x-gst-id3v2-ada

DEBUG (0x90bad80 - 0:00:00.547121000)             id3v2mux(22393)
gstid3v2mux.cc(174):void add_one_tag(const GstTagList*, const gchar*, void*):
Setting title to Ready Lets Go
DEBUG (0x90bad80 - 0:00:00.547345000)             id3v2mux(22393)
gstid3v2mux.cc(192):void add_one_tag(const GstTagList*, const gchar*, void*):
Setting artist to Boards Of Canada
DEBUG (0x90bad80 - 0:00:00.547512000)             id3v2mux(22393)
gstid3v2mux.cc(464):void add_one_tag(const GstTagList*, const gchar*, void*):
Setting binary blob of length 151701320 and mime-type
application/x-gst-id3v2-ada

Will attach file.


-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.